Zoo please accept my appreciation for you taking the time to do this mod. I think this mod was way overdue and should have been included as a default function in YaBB 2.0 ,2.1 and the future 2.2

Many thanks

Ok I tested the hard approval settings. I have a couple problems.

1- After registering the user gets the following message

Quote:

This should say that the registration is successful and is pending approval at which time an email will be sent out with your activation code.

2- The email I specify in the forum settings for "Send email with new (pre)registration" doesn't save and its blanked out after I try to save the forum settings. An email to that address is not being sent out after a user pre-registers (probably because it doesn't save properly).

3- Admin approval section - Small typo in the popup window when asked to confirm that you really want to approve the selected registration(s). The text should be "Do you really want to approve the selected registrations?" I haven't tested the delete confirmation but I would assume that one would have to be re-worded as well.

4- v1.3 mod file in step 2 has an extra space in the "search for" code that makes it fail when the mod is applied in boardmod

5- v1.3 mod file step 9 is missing a period at the end of the "search for" code that causes it to fail. (at least in my case it does)

Ok I tested it again.

I get the following error now
Quote:



Maybe you should make it clearer that the "Send email with new (pre)registration" space is for a username instead of "to:"

Ok there are a few more bugs

1- I registered with a username/email that already existed and was denied but I received a "new pre-registered member" email even though the registration was denied. I deleted the member in the approval/delete section in the admin center and tried registering a 2nd time. I was again denied because the user still existed and I got another "pre-reg" email. I had to go to the registration log section in the admin center and delete the user there . I than re-registered again a 3rd time and was successful and also receieved a 3rd "pre-reg" email. Emails below

1st email
Quote:

2nd email
Quote:

3rd email
Quote:


It should not send email unless successful. Also what is this new member number?? I only have 45 registered members on my forum. The email sent to the admin should have all the registration data (i.e. username , email, real name , etc.) except the user's password and also a proper link to the approval section of the forum. As you can see the email I received has an incomplete link and there a typo in the subject line, missing a space after the word "on"

2- In approval/delete section I deleted the existing member and it went away in that section but the user still existed. I had to go to the registration log section to delete the user.  I think you should either merge the registration log section and the approval/delete member section because they are redundant.

3- After the admin approves the registration the subject line in the  email sent to the pre-reg member doesn't read right. It says "Welcome, !" I'm thinking that the username should be inserted after "Welcome, "

Very good update so far.


I am missing a function I believe. I only want to approve a pre-regged member once. Meaning if the member registers I should get a  "New Member, approval required" email, I go and approve him and thats all. Why do you have to approve twice on a pre-regged registration? I can see why you would want hard and soft settings when you let members activate first before being approved because you want them to be limited in what they can do but when using pre-reg approvals, the member cannot access the forum anyway so approving him twice is redundant.

On a pre-reg registeration the following should happen.

1- member applies
2- admin recieves a "new member, Approval required" email
3- admin approves/denies registration
4- if approved "account approved/activation required" email is sent out to new member
5-member activates his account and has normal access to the forum


One other thing. You should change how you call the "Approval/Delete Members" section because its confusing with the existing "View/Delete Members" section. Maybe you could call it "Approve/Deny members" instead


This mod is really coming along nicely. We are almost there.


I changed the following in the approval.lng file

'need'			 => "Approval Method",
'no'			   => "No Approval Needed",
'soft'			 => "Approval Needed, View Mode Only",
'hard'			 => "Approval Needed, Profile Access Only",
'needpre'		    => "Approval before account activation? <br /><span style='font-size: 10px'>(checked=Before Activation, unchecked=After Activation)",
'sendmail'		   => "Send approval email with new registration",
'sendto'		     => "Pre-Reg Approval email sent to:<br /><span style='font-size: 10px'>(specify admin/gmod username(s) separated by comma or space)</span>",
 

Even if I turn pre-reg off and let the member activate his account first before I have to approve him, I get an pre-reg email and its not pre-reg

Quote:


But the more I think of it, there is no need to send a different email to the admin whether its pre-reg or full-reg, because I know how I set the options in the forum settings. Therefore just send the admin an email stating that "New member (member name),  approval needed" regardless if it is pre-reg or full-reg

Found another bug. With pre-reg off (meaning member activates before I get an approval required email) I get 2 instances of the same member appying in the approval list in the admin center. It shows me 2 approval for the same member at the same time. Should only be one approval. The twist is if I only approve one of them and click approve, they both disappear from the list.

Zoo wrote on Apr 20^th, 2007 at 8:18pm:

Maybe I wasn't clear enough.

When using pre-reg mode the the activation time should only start once the admin/gmod approves the member's account and not when the member submits his registration for approval. After it is approved the member receives an email saying "account is approved and waiting for his activation". No more emails needs to be sent to the admin/gmod. Once the member activates his account then he should have full access to the forum. The admin/gmod only needs to receive one email. hard and soft restrictions should not be used here because there's no need. the member cannot access the forum without first activating his account. The the "activation required" email is only sent the the member after the admin/gmod approves his account. So he can never access the forum until the member is approved.

When using full-reg mode then the activation time starts right away because the member is allowed to activate his account immediately but will only have either soft or hard restricted access to the forum until admin/gmod approves the member's account. Again only one email needs to be sent to the admin/gmod

What I was saying is in both situations whether using pre-reg or full-reg mode only ONE email needs to be sent to the admin/gmod and the email that is sent to the admin/gmod does not have to say in the subject line that it is "full-reg" or "pre-reg" because the admin/gmod already knows that all the approval emails will be either full-reg or pre-reg depending which approval mode is set in the forum settings.  All it has to say that there is a new member and he is waiting for approval. The admin/gmod already knows if its a pre-reg or full-reg member.

D0T-C0M wrote on Apr 20^th, 2007 at 10:08pm:


find in Register.pl (or MOD)

		&NeedApprovalSet;
		if ($needapproval && $needapprovalpre) { 

and replace with

		if ($needapproval && $needapprovalpre) {
		&NeedApprovalSet; 

Quote:

to you
find in Register.pl (or MOD)

				$emailsubject = $preregister ? $approval_txt{'newprereg'} : $approval_txt{'newreg'}; 

and replace with

				$emailsubject = $approval_txt{'newreg'}; 

but not tested