(UTC)
 Choose Language:
  BoardMod Mirror › YaBB 2 Mods › BETA Mods for YaBB 2/2.1 › Reverse Post Order beta 1.4 YaBB2
‹ Previous Topic | Next Topic ›
Page Index Toggle Pages: 1 2 3 [4] 5  Send TopicPrint
Very Hot Topic (More than 25 Replies) Reverse Post Order beta 1.4 YaBB2 (Read 26040 times)
Flowageboy
New Member
*
Offline


Hunt em up!

Posts: 45
Location: Stevens Point
Joined: Feb 20th, 2005
Gender: Male
Re: Reverse Post Order beta 1.4 YaBB2
Reply #45 - Feb 3rd, 2006 at 9:24pm
Print Post  
is this mod ready for final yet?
  
Back to top
 
IP Logged
 
astropilot
God Member
*****
Offline



Posts: 828
Location: Louisville
Joined: Jun 18th, 2003
Gender: Male
Re: Reverse Post Order beta 1.4 YaBB2
Reply #46 - Feb 4th, 2006 at 10:36pm
Print Post  
I think it is very close if not there already. I really haven't heard too much feedback.  Bumping this like you did will help.

Just for the record, I use this on a production board and have used this in a clean test board without issue on both, that I have seen.

ap
  
"For I am not ashamed of the gospel of Christ..."
Romans 1:16
---
http://www.ssflynn.com
www.flynnfarmsofkentucky.com
Back to top
 
IP Logged
 
hydepark2
Junior Member
**
Offline


I love YaBB 1G - SP1.2!

Posts: 80
Joined: Jun 28th, 2005
Re: Reverse Post Order beta 1.4 YaBB2
Reply #47 - Feb 5th, 2006 at 5:57am
Print Post  
I've been using this since it was released and I haven't had any issues. I say final.
  
Back to top
 
IP Logged
 
Imp_In_Training
God Member
*****
Offline


Don't follow me, I'm lost
too!

Posts: 608
Location: Aberdeen
Joined: Jun 17th, 2004
Gender: Male
Re: Reverse Post Order beta 1.3a YaBB2
Reply #48 - Feb 21st, 2006 at 3:30pm
Print Post  
astropilot wrote on Dec 14th, 2005 at 1:05am:
I did find one unrelated previously unknown problem.  The Notify2 and Notify3 sub routines do not redirect correctly (sends you to the wrong page).  But as I said, even that did not give the error you speak of.

Hey there ...

I've been running reverse order for a while and I did notice something.  But I'm running beta 1.3.  Maybe you've already taken care of it.

I have turned my browser so that it tries to debug script errors when detected.  When using reverse order posts and going directly into the thread, a run-time error shows up.  When clicking on one of the individual pages (0, 1, 2, 3... etc), the error is not present.  In normal order, the script error is not present.  It seems to be associated with some javascript associated with reversing the orders of threads.

For an example, you can feel free to make an account at the Dark and Moody Forums, switch to reverse order, and go into any message thread using IE. with the Advanced settings configured so that script debugging is enabled.  You'll see what I mean.

I don't know if you took care of this with your most recent revision (1.4), but I'll find out later this evening.
  
Back to top
WWW  
IP Logged
 
Imp_In_Training
God Member
*****
Offline


Don't follow me, I'm lost
too!

Posts: 608
Location: Aberdeen
Joined: Jun 17th, 2004
Gender: Male
Re: Reverse Post Order beta 1.4 YaBB2
Reply #49 - Feb 22nd, 2006 at 12:08am
Print Post  
After installing 1.4, the Runtime error is changed.  Now it simply says: "Problems with this Web page might prevent it from being displayed properly or functioning properly.  Puts the Syntax error at line 192, char 17.

This corresponds with the following source code:
Code
Select All
		<script language="JavaScript1.2" type="text/javascript">
			<!-- Begin
				var mnum = 1134938109;
				var postnum = location.hash;
				var address = "http://darkandmoodyforums.com/cgi-bin/yabb2/YaBB.pl?num=";
				var start = ;
				postnum = postnum.replace("#","");
				if(postnum >= 458){start = 0; postnum = 458;}
				else{postnum = 458 - postnum;}
				location.replace(address+mnum+";revpost=yes;start="+start+"#"+postnum);
			//-->
		</script>

Line 192 is "var start = ;"

Again, if I select on one of the page numbers, the problem does not show up.  If I deselect 'reversed order' then the problem does not show up.
  
Back to top
WWW  
IP Logged
 
astropilot
God Member
*****
Offline



Posts: 828
Location: Louisville
Joined: Jun 18th, 2003
Gender: Male
Re: Reverse Post Order beta 1.4 YaBB2
Reply #50 - Feb 22nd, 2006 at 3:46am
Print Post  
I did not try this, but I do not try support a mod for a beta version of YabB.

Anyway, on line 87 of the mod try this instead

var start = $INFO{'start'} || 0;

ap
  
"For I am not ashamed of the gospel of Christ..."
Romans 1:16
---
http://www.ssflynn.com
www.flynnfarmsofkentucky.com
Back to top
 
IP Logged
 
Imp_In_Training
God Member
*****
Offline


Don't follow me, I'm lost
too!

Posts: 608
Location: Aberdeen
Joined: Jun 17th, 2004
Gender: Male
Re: Reverse Post Order beta 1.4 YaBB2
Reply #51 - Feb 22nd, 2006 at 2:56pm
Print Post  
This didn't change the error.  Same problem.  It seems the system is evaluating that $INFO{'start'} to null and that doesn't work with the source, providing a script error ... ie. "var start =  || 0;" is what the browser sees.
  
Back to top
WWW  
IP Logged
 
Imp_In_Training
God Member
*****
Offline


Don't follow me, I'm lost
too!

Posts: 608
Location: Aberdeen
Joined: Jun 17th, 2004
Gender: Male
Re: Reverse Post Order beta 1.4 YaBB2
Reply #52 - Feb 22nd, 2006 at 3:00pm
Print Post  
What if I change it to:
Code
Select All
if ($INFO{'start'} == null) {
  var start = 0
} else {
  var start = $INFO{'start'}
}
  
Back to top
WWW  
IP Logged
 
Imp_In_Training
God Member
*****
Offline


Don't follow me, I'm lost
too!

Posts: 608
Location: Aberdeen
Joined: Jun 17th, 2004
Gender: Male
Re: Reverse Post Order beta 1.4 YaBB2
Reply #53 - Feb 22nd, 2006 at 3:15pm
Print Post  
Nope, that didn't work either.  Although the logic is there, the script still interprets $INFO{'start'} before it's called in the display.pl file.
  
Back to top
WWW  
IP Logged
 
astropilot
God Member
*****
Offline



Posts: 828
Location: Louisville
Joined: Jun 18th, 2003
Gender: Male
Re: Reverse Post Order beta 1.4 YaBB2
Reply #54 - Feb 22nd, 2006 at 9:09pm
Print Post  
try this after fclose(MSGTXT);

if (!$INFO{'start'}) {$INFO{'start'} = 0;}

This will do in perl what I wanted to do in js.

ap
  
"For I am not ashamed of the gospel of Christ..."
Romans 1:16
---
http://www.ssflynn.com
www.flynnfarmsofkentucky.com
Back to top
 
IP Logged
 
Imp_In_Training
God Member
*****
Offline


Don't follow me, I'm lost
too!

Posts: 608
Location: Aberdeen
Joined: Jun 17th, 2004
Gender: Male
Re: Reverse Post Order beta 1.4 YaBB2
Reply #55 - Feb 23rd, 2006 at 12:46am
Print Post  
Yup, sure does.  Now I'd say it's ready for the grade-a stamp of approval.
  
Back to top
WWW  
IP Logged
 
spyderweb
New Member
*
Offline


visit www.spyderweb.n
l

Posts: 39
Joined: Apr 22nd, 2006
Re: Reverse Post Order beta 1.4 YaBB2
Reply #56 - Apr 23rd, 2006 at 12:24am
Print Post  
I cannot delete a message when "Reverse Post Order" selected.
When I change "revers == 'on'" to "revers == 'oon'" I can.
I use the latest Yabb 2.1 files.

Quote:
           var revers = "${$uid.$username}{'reverse_posts'}";
           if (revers == 'on'){
                 var z = 0;
                 for (var i = $#msgtxt - $start; z < $maxmessagedisplay; i--) {
                       if(i == counter) {document.multidel.elements[z].checked = true;}
                       else {document.multidel.elements[z].checked = false;}
                       z++;
                 }
           }
  
Back to top
WWW  
IP Logged
 
spyderweb
New Member
*
Offline


visit www.spyderweb.n
l

Posts: 39
Joined: Apr 22nd, 2006
Re: Reverse Post Order beta 1.4 YaBB2
Reply #57 - Apr 24th, 2006 at 12:17pm
Print Post  
astropilot wrote on Feb 22nd, 2006 at 9:09pm:
try this after fclose(MSGTXT);

if (!$INFO{'start'}) {$INFO{'start'} = 0;}

This will do in perl what I wanted to do in js.

ap


A different solution is to put quotes around the string:

Quote:
var start = "$INFO{'start'}";
  
Back to top
WWW  
IP Logged
 
Imp_In_Training
God Member
*****
Offline


Don't follow me, I'm lost
too!

Posts: 608
Location: Aberdeen
Joined: Jun 17th, 2004
Gender: Male
Re: Reverse Post Order beta 1.4 YaBB2
Reply #58 - Aug 15th, 2006 at 1:08pm
Print Post  
spyderweb wrote on Apr 23rd, 2006 at 12:24am:
I cannot delete a message when "Reverse Post Order" selected.
When I change "revers == 'on'" to "revers == 'oon'" I can.
I use the latest Yabb 2.1 files.


I am seeing the same problem.  It only seems to be a problem for regular users on my board.  If you are a moderator or admin, the checkbox removal takes care of things nicely.

I tried changing "revers == 'on'" to "revers == 'oon'".  It does get rid of the script error, but the message isn't deleted then.  It acts like it does what it's supposed to, but doesn't.
  
Back to top
WWW  
IP Logged
 
astropilot
God Member
*****
Offline



Posts: 828
Location: Louisville
Joined: Jun 18th, 2003
Gender: Male
Re: Reverse Post Order beta 1.4 YaBB2
Reply #59 - Aug 16th, 2006 at 1:31am
Print Post  
Imp,

I have come to a crossroad in my life and may not be able to continue modding due to time constraints.  Anyway, I haven't decided to release all my mods yet, but I am considering it.  (It seems that others have already started fixxing my mods without even asking first.)  I do need a hobby from medicine.

Anyway, if I decide to stay on, I will fix my old mods first.

ap
  
"For I am not ashamed of the gospel of Christ..."
Romans 1:16
---
http://www.ssflynn.com
www.flynnfarmsofkentucky.com
Back to top
 
IP Logged
 
Page Index Toggle Pages: 1 2 3 [4] 5 
Send TopicPrint
‹ Previous Topic | Next Topic ›
 
  « Board Index ‹ Board Top  

BoardMod Mirror » Powered by YaBB 2.6.12!
YaBB Forum Software © 2000-2024. All Rights Reserved.

Valid RSS Valid XHTML Valid CSS Powered by Perl Source Forge