Page Index Toggle Pages: [1] 2  Send TopicPrint
Hot Topic (More than 10 Replies) Add Message Icons bug (Read 6212 times)
Steve Stegeman
Guest


Add Message Icons bug
Sep 3rd, 2002 at 7:26am
Print Post  
Hi,

Noticed a problem after installing the "Add Message Icons" mod, which, by the way is great and very easy to install.  Anyway, if a user chooses an "added message icon" and then previews, the "message icon" reverts back to the "Standard" icon; making things worse, the picture of the icon remains the same, i.e. it still shows the original (added) one selected.  Any ideas on how to fix this would be much appreciated!

Thanks! 8)
  
Back to top
 
IP Logged
 
StegRock
New Member
*
Offline


I love YaBB 1G - SP1!

Posts: 44
Joined: Sep 3rd, 2002
Re: Add Message Icons bug
Reply #1 - Sep 3rd, 2002 at 8:10am
Print Post  
I just noticed that this also happens when you go to "modify" a post!
  

If you have the time, drop on by http://www.fantasyfootballer.com and http://www.theenglishmaster.com and say, "Hi!"
Back to top
WWW  
IP Logged
 
Shoeb Omar
God Member
*****
Offline


Mod Writer

Posts: 5665
Location: San Diego
Joined: Jun 29th, 2001
Gender: Male
Re: Add Message Icons bug
Reply #2 - Sep 3rd, 2002 at 11:19pm
Print Post  
which version are you using?
  

YaBB SP2 BETA!
Now taking pay jobs in PHP or Perl.  Contact me for details.
Back to top
IP Logged
 
EliteRides
God Member
*****
Offline


EliteRides.com !

Posts: 692
Location: Salt Lake City
Joined: Mar 23rd, 2002
Gender: Male
Re: Add Message Icons bug
Reply #3 - Sep 4th, 2002 at 12:17am
Print Post  
No problems on mine.  Tried modifying and previewing.
  

ElietRides.com

Nice cars and just a bunch of hotties...  Grin
Back to top
WWW  
IP Logged
 
StegRock
New Member
*
Offline


I love YaBB 1G - SP1!

Posts: 44
Joined: Sep 3rd, 2002
Re: Add Message Icons bug
Reply #4 - Sep 4th, 2002 at 4:52am
Print Post  
Quote:
which version are you using?


YaBB 1 Gold - SP 1.1!

Thanks for your anticipated assistance and sorry 'bout forgetting to state what version I am using the first time around! Embarrassed
  

If you have the time, drop on by http://www.fantasyfootballer.com and http://www.theenglishmaster.com and say, "Hi!"
Back to top
WWW  
IP Logged
 
Shoeb Omar
God Member
*****
Offline


Mod Writer

Posts: 5665
Location: San Diego
Joined: Jun 29th, 2001
Gender: Male
Re: Add Message Icons bug
Reply #5 - Sep 5th, 2002 at 12:49am
Print Post  
StegRock wrote on Sep 4th, 2002 at 4:52am:
YaBB 1 Gold - SP 1.1!

Thanks for your anticipated assistance and sorry 'bout forgetting to state what version I am using the first time around! Embarrassed


I meant of the mod Smiley
  

YaBB SP2 BETA!
Now taking pay jobs in PHP or Perl.  Contact me for details.
Back to top
IP Logged
 
Jake
God Member
*****
Offline



Posts: 1265
Location: asia
Joined: Jun 22nd, 2002
Gender: Male
Re: Add Message Icons bug
Reply #6 - Sep 5th, 2002 at 10:26pm
Print Post  
StegRock wrote on Sep 3rd, 2002 at 8:10am:
I just noticed that this also happens when you go to "modify" a post!

same on my board ,i use  Add_more_messageIcon ver.1.6
the icon that usually returned back when i modified the message was xx.gif
  

   
Back to top
 
IP Logged
 
StegRock
New Member
*
Offline


I love YaBB 1G - SP1!

Posts: 44
Joined: Sep 3rd, 2002
Re: Add Message Icons bug
Reply #7 - Sep 7th, 2002 at 11:21am
Print Post  
Same as Jake, 1.6, newest one out! Grin
  

If you have the time, drop on by http://www.fantasyfootballer.com and http://www.theenglishmaster.com and say, "Hi!"
Back to top
WWW  
IP Logged
 
Jake
God Member
*****
Offline



Posts: 1265
Location: asia
Joined: Jun 22nd, 2002
Gender: Male
Re: Add Message Icons bug
Reply #8 - Sep 7th, 2002 at 6:37pm
Print Post  
And sometimes  the message icon showed as the red mark URL although i had put the absolutely right image file ???
  

   
Back to top
 
IP Logged
 
StegRock
New Member
*
Offline


I love YaBB 1G - SP1!

Posts: 44
Joined: Sep 3rd, 2002
Re: Add Message Icons bug
Reply #9 - Oct 9th, 2002 at 11:49am
Print Post  
I see nothing wrong with a little BUMP-n-griiiiiihihuhuhihuhuiiiiiiiind!

Is anybody out there?


Whether I sing it in hip-hop or acid-rock, there is just no makin' this problem sound okay.  Can anybody give a guy a hand here, not a standing O, just a hand? Grin Thanks!
  

If you have the time, drop on by http://www.fantasyfootballer.com and http://www.theenglishmaster.com and say, "Hi!"
Back to top
WWW  
IP Logged
 
Jake
God Member
*****
Offline



Posts: 1265
Location: asia
Joined: Jun 22nd, 2002
Gender: Male
Re: Add Message Icons bug
Reply #10 - Oct 21st, 2002 at 12:12pm
Print Post  
I found that when the name of message icon cotained some characters such as digit or _ .it cann't not read the gif file Grin
Just rename and remove such a character Wink
  

   
Back to top
 
IP Logged
 
StegRock
New Member
*
Offline


I love YaBB 1G - SP1!

Posts: 44
Joined: Sep 3rd, 2002
Re: Add Message Icons bug
Reply #11 - Nov 8th, 2002 at 11:53am
Print Post  
Quote:
I found that when the name of message icon cotained some characters such as digit or _ .it cann't not read the gif file Grin
Just rename and remove such a character Wink


Jake, thanks for responding!  I have made the same realization, actually, though not in connection with this problem.  This is not the case here.  The ".gif" being called is either "xx.gif" or "open.gif" which is actually the same picture.  With a friend, we have actually gotten this far...

The problem seems to be with the "sub CheckIcon" code in "Security.pl".  We changed it to:

Code
Select All
sub CheckIcon

{

$icon =~ s/[^A-Za-z|\/]//g;

$icon_found=0;

unless($icon eq "xx" || $icon eq "thumbup" || $icon eq "thumbdown" || $icon eq "exclamation") {

unless($icon eq "question" || $icon eq "lamp" || $icon eq "smiley" || $icon eq "angry") {

unless($icon eq "cheesy" || $icon eq "laugh" || $icon eq "sad" || $icon eq "wink") {

$icon = "xx";

$icon_found=1;

}

}

}

else

{

$i=0;

while($MIconURL[$i] && !$icon_found)

{

if ($icon eq $MIconURL[$i])

{

$icon_found=1;

}

$i++;

}

}

} 



Now, though I get the (lousy) icon on the "Instant Messenger" preview page, none of my "added" message icons display.

Any further help anyone?
  

If you have the time, drop on by http://www.fantasyfootballer.com and http://www.theenglishmaster.com and say, "Hi!"
Back to top
WWW  
IP Logged
 
Shoeb Omar
God Member
*****
Offline


Mod Writer

Posts: 5665
Location: San Diego
Joined: Jun 29th, 2001
Gender: Male
Re: Add Message Icons bug
Reply #12 - Nov 8th, 2002 at 11:01pm
Print Post  
I could've sworn i fixed this ages ago, and there was an add more message icons v2...

I can't find one Undecided

Whoa: http://boardmod.yabbforum.com/yabb/YaBB.pl?board=newssp;action=display;num=10089...

Seems like the same problem. Don't worry too much guys, I'll fix it soon Cheesy
  

YaBB SP2 BETA!
Now taking pay jobs in PHP or Perl.  Contact me for details.
Back to top
IP Logged
 
Shoeb Omar
God Member
*****
Offline


Mod Writer

Posts: 5665
Location: San Diego
Joined: Jun 29th, 2001
Gender: Male
Re: Add Message Icons bug
Reply #13 - Nov 9th, 2002 at 6:53pm
Print Post  
ok, it's fixed, but before I officially release it,please test the changes I've made:

in post.pl, find:

Code
Select All
~;
	$i=0;
	while($MIconURL[$i]) {
		$extra .= qq~<option value="$MIconURL[$i]">$MessIDescription[$i]\n~;
	$i++;
	}
$extra .= qq~
 



and replace it with:

Code
Select All
~;
	$i=0;
	while($MIconURL[$i]) {
		$extra .= qq~<option value="$MIconURL[$i]"$messicon[$i]>$MessIDescription[$i]\n~;
	$i++;
	}
$extra .= qq~
 



then search for:

Code
Select All
	elsif($icon eq "wink") { $ic12 = " selected"; } 



and add after it:

Code
Select All
	$i=0;
	while($MIconURL[$i]) {
		if ($icon eq "$MIconURL[$i]"){$messicon[$i] = " selected";}
	$i++;
	} 



Also, for a small display fix, in Admin.pl search for:

Code
Select All
	  <a href="$cgi&action=micon">$mitxt{'01'}</a><br> 



and rpelace that with:

Code
Select All
	  - <a href="$cgi&action=micon">$mitxt{'01'}</a><br> 




An updated zip is also attached.

  

messicons17.zip ( 2 KB | Downloads )

YaBB SP2 BETA!
Now taking pay jobs in PHP or Perl.  Contact me for details.
Back to top
IP Logged
 
StegRock
New Member
*
Offline


I love YaBB 1G - SP1!

Posts: 44
Joined: Sep 3rd, 2002
Re: Add Message Icons bug
Reply #14 - Nov 16th, 2002 at 1:38pm
Print Post  
Hold the presses!  Didn't work!  Actually here is what I noticed:

The single problematic line according to your fix is:
Code
Select All
  $extra .= qq~<option value="$MIconURL[$i]">$MessIDescription[$i]\n~; 



Your suggested change was:
Code
Select All
  $extra .= qq~<option value="$MIconURL[$i]"$messicon[$i]>$MessIDescription[$i]\n~; 



BUT, ACTUALLY THE LINE IN MY POST.PL LOOKS LIKE THIS:
Code
Select All
  $extra .= qq~<option value="$MIconURL[$i]"$ic[$i]>$MessIDescription[$i]\n~; 



Anyway, thanks for the small admin fix!  I just hope we can eventually conquer the "bigger" problem here! Roll Eyes
  

If you have the time, drop on by http://www.fantasyfootballer.com and http://www.theenglishmaster.com and say, "Hi!"
Back to top
WWW  
IP Logged
 
Page Index Toggle Pages: [1] 2 
Send TopicPrint