Page Index Toggle Pages: 1 2 [3] 4  Send TopicPrint
Very Hot Topic (More than 25 Replies) Message Approval (Read 30506 times)
Zoo
Senior Member
****
Offline


I love YaBB 1G - SP1!

Posts: 290
Joined: Jan 22nd, 2003
Re: Message Approval
Reply #30 - May 15th, 2007 at 6:32am
Print Post  
have you this
Code
Select All
		$outblock =~ s/<yabb approval>/$approval/g; 

in Display.pl?
  
Back to top
 
IP Logged
 
ccarr
Ex Member


Re: Message Approval
Reply #31 - May 15th, 2007 at 12:30pm
Print Post  
Thanks Zoo

Yes I do

Code
Select All
		$outblock =~ s/<yabb signature>/${$uid.$musername}{'signature'}/g;
		$outblock =~ s/<yabb approval>/$approval/g;
		$outblock =~ s/<yabb signaturehr>/$signature_hr/g; 



Any other suggestions?

Thanks
  
Back to top
 
IP Logged
 
Zoo
Senior Member
****
Offline


I love YaBB 1G - SP1!

Posts: 290
Joined: Jan 22nd, 2003
Re: Message Approval
Reply #32 - May 16th, 2007 at 4:39am
Print Post  
suggestions?

1. Add 'Approved by .. enable?

2. find [approval]admin/your username[/approval] in thread.txt. Found?

3.replace
Code
Select All
$outblock =~ s/<yabb approval>/$approval/g; 

with
Code
Select All
$outblock =~ s/<yabb approval>/TEST : $approval/g; 

look an approved message. have you TEST  to display?
  
Back to top
 
IP Logged
 
ccarr
Ex Member


Re: Message Approval
Reply #33 - May 16th, 2007 at 4:55pm
Print Post  
Thanks again Zoo.

For 1. If you mean, do I have Approved by enabled then I believe that I do. Please see Attached picture.

For 2. The thread.txt only has this:

Code
Select All
{\rtf1\ansi\ansicpg1252\deff0\deflang2057{\fonttbl{\f0\fswiss\fcharset0 Arial;}}
{\*\generator Msftedit *.**.**.****;}\viewkind4\uc1\pard\f0\fs20 ome  ||1179173095|admin|\par
} 


I removed the IP numbers

For 3. I replaced the code and now get this in the approved message:

 « Last Edit: May 14th, 2007, 9:04pm by Admin » TEST :

When I check every other normal message I now get this text at the bottom of each message:

TEST :

Any other ideas? If not don't worry as it's not that important but would be nice to have working.

I have also added more code from my display.template in case I have done something wrong here. I hope that's ok?


Code
Select All
###############################################################################
# Display.template                                                            #
###############################################################################
# YaBB: Yet another Bulletin Board                                            #
# Open-Source Community Software for Webmasters                               #
# Version:        YaBB 2.1                                                    #
# Released:       November 8, 2005                                            #
# Distributed by: http://www.yabbforum.com                                    #
# =========================================================================== #
# Copyright (c) 2000-2005 YaBB (www.yabbforum.com) - All Rights Reserved.     #
# Software by: The YaBB Development Team                                      #
#              with assistance from the YaBB community.                       #
# Sponsored by: Xnull Internet Media, Inc. - http://www.ximinc.com            #
#               Your source for web hosting, web design, and domains.         #
###############################################################################


$threadhandellist = qq~
	<yabb reply><yabb poll><yabb notify><yabb favorite><yabb sendtopic><yabb print><yabb markunread>
~;

$adminhandellist = qq~
	<yabb move><yabb remove><yabb splice><yabb lock><yabb hide><yabb sticky><yabb multidelete><yabb ratingt>
~;

$display_template = qq~

<!-- Navigation Bar start -->

<div class="navbarcontainer">
<table width="100%" border="0">
<tr>
	<td align="left">
	<span class="small">
		<b><yabb home> › <yabb category> › <yabb parentboards><yabb board></b> <yabb moderators>
	</span>
	</td>
	<td valign="bottom" align="right">
	<span class="small">
		‹ <yabb prev> | <yabb next> ›
	</span>
	</td>
</tr>
</table>
</div>

<!-- Navigation Bar end -->


<!-- Poll start -->

<yabb pollmain>

<!-- Poll end -->


<!-- Threads Button Bar start -->

<div class="displaycontainer">
<table cellpadding="4" cellspacing="0" border="0" width="100%" align="center">
<tr>
	<td class="catbg" valign="middle" align="left">
	<div style="float: left; text-align: left;">
		<yabb pageindex top>
	</div>
	<div style="float: right; text-align: right;">
		<yabb threadhandellist>
	</div>
	</td>
</tr>
</table>
</div>

<!-- Threads Button Bar end -->


<!-- Threads Title Bar start -->
<yabb topicbrating>
<div class="displaycontainer">
<table cellpadding="4" cellspacing="0" border="0" width="100%" align="center">
<yabb topicviewers>
<tr>
	<td class="titlebg" valign="middle" align="left">
		<yabb threadimage> <yabb threadurl> ($display_txt{'641'} <yabb views> $display_txt{'642'})
	</td>
</tr>
</table>
</div>

<!-- Threads Title Bar end -->
<yabb tdescription>


<!-- Threads block start, should be left as is -->

	<yabb multistart>
	<yabb postsblock>
	<yabb multiend>

<!-- Threads block end, should be left as is -->


<!-- Threads Button Bar start -->

<div class="displaycontainer">
<div style="clear: both;"></div>
<yabb topicarating>
<table cellpadding="4" cellspacing="0" border="0" width="100%" align="center">
<tr>
	<td class="catbg" valign="middle" align="left">
	<div style="float: left; text-align: left;">
		<yabb pageindex bottom>
	</div>
	<div style="float: right; text-align: right;">
		<yabb threadhandellist>
	</div>
	</td>
</tr>
</table>
</div>

<!-- Threads Button Bar end -->


<!-- Navigation Bar start -->

<div class="navbarcontainer">
<table width="100%" border="0">
<tr>
	<td align="left">
	<span class="small">
		<b><yabb home> › <yabb category> › <yabb parentboards><yabb board></b> <yabb moderators>
	</span>
	</td>
	<td valign="top" align="right">
	<span class="small">
		‹ <yabb prev> | <yabb next> ›
	</span>
	</td>
</tr>
</table>
</div>

<!-- Navigation Bar end -->


<!-- Threads Admin Button Bar and Jump box start -->

<div style="margin: 4px;">
<table cellpadding="4" cellspacing="0" border="0" width="100%">
<tr>
	<td align="left" valign="top">
		<span class="small"><yabb adminhandellist></span>
	</td>
	<td align="right">
		<yabb forumselect>
	</td>
</tr>
</table>
</div>

<!-- Threads Admin Button Bar and Jump box end -->

~;



# Member info and message block (yabb postsblock) #

$posthandellist = qq~
	<yabb alertmod>
	<yabb qquote><yabb quote><yabb modify><yabb split><yabb delete>&nbsp;<yabb admin>
~;

$contactlist = qq~
	<yabb email><yabb profile><yabb pm><yabb www><yabb msn><yabb gtalk><yabb icq><yabb yim><yabb aim>
~;

$messageclass = "message";

$messageblock = qq~
<div class="displaycontainer">
<table cellpadding="4" cellspacing="0" border="0" width="100%" class="bordercolor" align="center" style="table-layout: fixed;">
<tr>
	<td align="left" class="<yabb css>" valign="top" width="140">
		<a name="<yabb count>"></a>
		<yabb qqname><yabb userlink>
		<div class="small">
		<yabb topicstarter>
		<yabb memberinfo><br />
		<yabb stars><br /><br />
		<yabb userpic>
		<yabb usertext><br />
		<yabb postinfo>
		<yabb userrepa><br /><br />
		<yabb gender>
		</div>
	</td>
	<td class="<yabb css>" align="left" valign="top">
		<div style="float: left; width: 99%; padding-top: 2px; padding-bottom: 4px; margin-bottom: 2px;" class="dividerbot">
		<span class="small" style="float: left; width: 3%; text-align: center; padding: 2px;"><yabb msgimg></span>
		<span class="small" style="float: left; width: 46%; vertical-align: middle;">
			<b><yabb subject></b><br />
			<span class="small"><b><yabb replycount></b><yabb msgdate></span>
		</span>
		<span class="small" style="float: left; text-align: right; width: 50%;">
			<yabb posthandellist>

		</span>
		</div>
		<div onmouseup="get_selection();" class="$messageclass" style="float: left; width: 99%; overflow: auto;">
			<yabb message>
		</div>
	</td>
</tr>
<tr>
	<td class="<yabb css>" valign="bottom">
		<a href="#top">$display_txt{'643'}</a>
	</td>
	<td class="<yabb css>" align="left" valign="bottom">
		<div class="small" style="float: left; width: 49%; text-align: left;">
			<yabb att> &nbsp;
		</div>
		<div class="small" style="float: left; width: 50%; text-align: right;">
			<yabb modified>&nbsp;<yabb approval><yabb reason>
		</div>
		<div class="small" style="float: left; width: 99%; text-align: left">
			<yabb showatthr><yabb showatt>
		</div>
		<div class="small" style="float: left; width: 99%; text-align: left;">
			<yabb signaturehr><yabb signature>
		</div>
		<div style="float: left; width: 99%; padding-top: 5px; margin-top: 5px;" class="dividertop">
		<span class="small" style="float: left; width: 59%;">
			<yabb contactlist> &nbsp;
		</span>
		<span class="small" style="float: left; text-align: right; width: 40%;">
			<span class="small"><yabb ipimg> <yabb ip></span>
		</span>
		</div>
	</td>
</tr>
</table>
</div>
~;


$parentseparator = " - ";

1; 





[color=Yellow][/color]
  

settings.gif ( 13 KB | Downloads )
settings.gif
Back to top
 
IP Logged
 
Zoo
Senior Member
****
Offline


I love YaBB 1G - SP1!

Posts: 290
Joined: Jan 22nd, 2003
Re: Message Approval
Reply #34 - May 17th, 2007 at 6:50am
Print Post  
- settings and template are correct
- thead.txt: reason found, but approval code not found in it!

i try a quest message:
http://www.eulogia.co.uk/cgi-bin/forum/YaBB.pl?num=1179332595/0#1
it's good, i see "... This guests message is waiting to be approved!"

now you do click on what happen?
  
Back to top
 
IP Logged
 
ccarr
Ex Member


Re: Message Approval
Reply #35 - May 17th, 2007 at 7:21am
Print Post  
Thanks again Zoo

Message Approved.

http://www.eulogia.co.uk/cgi-bin/forum/YaBB.pl?num=1179332595/1#1

Should I try going through the full install again?

  
Back to top
 
IP Logged
 
Zoo
Senior Member
****
Offline


I love YaBB 1G - SP1!

Posts: 290
Joined: Jan 22nd, 2003
Re: Message Approval
Reply #36 - May 17th, 2007 at 8:09am
Print Post  
hmm..
found [approval] in 1179332595.txt now?
  
Back to top
 
IP Logged
 
Zoo
Senior Member
****
Offline


I love YaBB 1G - SP1!

Posts: 290
Joined: Jan 22nd, 2003
Re: Message Approval
Reply #37 - May 17th, 2007 at 8:16am
Print Post  
ok, this is a bug in display.pl

Code
Select All
		$outblock =~ s/<yabb approval>/$approval/g; 


replace with
Code
Select All
		$outblock =~ s/<yabb approval>/$mess_approvedby_txt/g; 

  
Back to top
 
IP Logged
 
Zoo
Senior Member
****
Offline


I love YaBB 1G - SP1!

Posts: 290
Joined: Jan 22nd, 2003
Re: Message Approval
Reply #38 - May 17th, 2007 at 12:01pm
Print Post  
i see: perfect  Wink
  
Back to top
 
IP Logged
 
ccarr
Ex Member


Re: Message Approval
Reply #39 - May 17th, 2007 at 12:22pm
Print Post  
Zoo

Fantastic. It is now working. Thanks for taking the time to check.  8)

One possible bug with this change that I noticed is this. On the first message I had originally edited the message and had something like this at the bottom of the message.

'Last Edit: May 14th, 2007, 9:04pm by Admin'

When I added this new code to the Display.pl the 'Last Edit' info was removed completely. This makes no difference to me and may only be related to my particular setup.  I though that I should mention it in case it was important to someone else. However, modifying the message shows the 'Last Edit' info correctly once again.

This is a great Mod.

Thanks Zoo
  
Back to top
 
IP Logged
 
ccarr
Ex Member


Re: Message Approval
Reply #40 - May 25th, 2007 at 7:18am
Print Post  
Zoo. I think there may be a major back door problem with this mod or is it only on my site? Cry

I had to go away for a few days and checked out my site at work. I often use the '10 most recent posts' link to see what's new. I wasn't logged in at the time. Unfortunately someone had left a message with a link to porn and an image. The porn was fully visible in the message for all to see. Is this only possible on my site or is this a problem with the mod? If it is then is there anything that can be done to stop the image being displayed to anyone who clicks on the '10 most recent posts' link?

Here is a test un-approved message on my site with a link to an image, it demonstrates the problem.

http://www.eulogia.co.uk/cgi-bin/forum/YaBB.pl?action=recent

Thanks for the help
  
Back to top
 
IP Logged
 
ccarr
Ex Member


Re: Message Approval
Reply #41 - May 27th, 2007 at 11:55pm
Print Post  
Hi

Just adding that the not yet approved image problem is also visible in the RSS Feed.

http://www.eulogia.co.uk/cgi-bin/forum/YaBB.pl?action=rss

Any thoughts on how to fix this?  ???

Thanks Again
  
Back to top
 
IP Logged
 
Zoo
Senior Member
****
Offline


I love YaBB 1G - SP1!

Posts: 290
Joined: Jan 22nd, 2003
Re: Message Approval
Reply #42 - May 28th, 2007 at 8:35am
Print Post  
@ccarr
recent posts bug : i know but was not spare time.  i building the new version tonight - maybe  Wink
  
Back to top
 
IP Logged
 
ccarr
Ex Member


Re: Message Approval
Reply #43 - May 28th, 2007 at 8:46am
Print Post  
Hi Zoo

That's great. Your mods are really appreciated.  8)
  
Back to top
 
IP Logged
 
Zoo
Senior Member
****
Offline


I love YaBB 1G - SP1!

Posts: 290
Joined: Jan 22nd, 2003
Re: Message Approval
Reply #44 - May 30th, 2007 at 12:39pm
Print Post  
@ccarr: sorry, i'm slow (my wife is in hospital and i'm home with my baby who 3 months old . very hard Wink)
  
Back to top
 
IP Logged
 
Page Index Toggle Pages: 1 2 [3] 4 
Send TopicPrint