BoardMod Mirror - [For Testing]SP1.2+ Notification fix

(UTC)

Choose Language:

BoardMod Mirror › YaBB 1 Mods › FINAL Mods for YaBB 1 SP1.2 › [For Testing]SP1.2+ Notification fix

‹ Previous Topic | Next Topic ›

Pages: 1

[For Testing]SP1.2+ Notification fix (Read 4454 times)

Dummy Proof God Member Offline I hate Bosses! Now get to work! Posts: 991 Location: Outside L.A. Joined: Aug 8^th, 2002 Gender:	[For Testing]SP1.2+ Notification fix May 6^th, 2003 at 11:38am	Print Post
	I was able to confirm that there is indeed a problem with how notifications are being written/removed to/from the .mail container files in SP1.2+ as reported in this thread: Members not being notified by email of new posts At first I didn't think there was a problem, but upon further testing I noticed that as soon as a email addy was added to an existing .mail file, the existing file would get unlinked and only one addy would get written to the file. I have reworked subs "Notify2, Notify3 and Notify4" and it appears to be working as desired. Due to the amount of code I would of had to post at YaBB Support thread, I decided to just post the whole file here, rather than have those who can test it have to cut and paste alot of code. MAKE SURE YOU RENAME THE ATTACHED FILE TO "Notify.pl" PRIOR TO PLACING IT IN THE "Sources" DIR. Michael and T-Master I hope you don't mind that I posted this here, if so please remove it and I'll post it in chunks at a YaBB Support forum thread. Thanks. DummyProof

	NotifyFIXED.txt ( 9 KB \| Downloads ) Ya can Idiot proof it... Ya can Dummy proof it... But ya can never... ...Blonde proof it!
	WWW IP Logged

Administrator Forum Administrator Offline Yummm Posts: 7 Location: Modders Rile Joined: Oct 7^th, 2014 Gender:	Re: [For Testing]SP1.2+ Notification fix Reply #1 - May 6^th, 2003 at 11:56am	Print Post
	The only necessary change I see is the removal of the unlink code in sub Notify2. All the other changes shouldn't really make any difference.

	The Administrator.
	WWW IP Logged

Dummy Proof God Member Offline I hate Bosses! Now get to work! Posts: 991 Location: Outside L.A. Joined: Aug 8^th, 2002 Gender:	Re: [For Testing]SP1.2+ Notification fix Reply #2 - May 6^th, 2003 at 12:01pm	Print Post
	Might very well be possible... I think though that the problem was that even if there was one addy in the file, the "if( $#mails eq 0)" was returning true. I think I just went ahead and changed the usage for safety sakes. But honestly you could be right. Dummy

	Ya can Idiot proof it... Ya can Dummy proof it... But ya can never... ...Blonde proof it!
	WWW IP Logged

Dummy Proof God Member Offline I hate Bosses! Now get to work! Posts: 991 Location: Outside L.A. Joined: Aug 8^th, 2002 Gender:	Re: [For Testing]SP1.2+ Notification fix Reply #3 - May 6^th, 2003 at 10:33pm	Print Post
	I agree totally with T-Master now after further testing. The only change needed is with Sub Notify2. I was initially having trouble with deleting(unlinking) the .mail files from "Show Notifications", so I assumed it was related to "$#mails" variable, when actually I have since found out I was using a Notify.pl file that still had the mislabeled "$thread.mail" that should of been "$threadno.mail". Dummy

	Ya can Idiot proof it... Ya can Dummy proof it... But ya can never... ...Blonde proof it!
	WWW IP Logged

Dummy Proof God Member Offline I hate Bosses! Now get to work! Posts: 991 Location: Outside L.A. Joined: Aug 8^th, 2002 Gender:	Re: [For Testing]SP1.2+ Notification fix Reply #4 - May 6^th, 2003 at 10:51pm	Print Post
	Michael, T-Master or Moderator I have posted a thread at the "proper" Forum . It addresses just the Sub Notify2, which really was the only bug. This whole thread should probably just be deleted please. Thanks, DummyProof

	Ya can Idiot proof it... Ya can Dummy proof it... But ya can never... ...Blonde proof it!
	WWW IP Logged

Shoeb Omar God Member Offline Mod Writer Posts: 5665 Location: San Diego Joined: Jun 29^th, 2001 Gender:	Re: [For Testing]SP1.2+ Notification fix Reply #5 - May 7^th, 2003 at 12:20am	Print Post
	sinc emike doesn't like deletions, I shall just lock it

	YaBB SP2 BETA! Now taking pay jobs in PHP or Perl. Contact me for details.
	WWW ICQ YIM AIM IP Logged

Christer Alexander God Member Offline Make my day... Posts: 3443 Location: Lethbridge Joined: Feb 10^th, 2002 Gender:	Re: [For Testing]SP1.2+ Notification fix Reply #6 - May 7^th, 2003 at 5:44am	Print Post
	Much better solution..

	Code unless(0) { stab("LoonyPandora"); next; }
	WWW ICQ YIM AIM IP Logged

Tea-Master Forum Administrator Offline Posts: 1945 Location: north germany Joined: Oct 21^st, 2001 Gender:	Re: [For Testing]SP1.2+ Notification fix Reply #7 - May 7^th, 2003 at 7:24am	Print Post
	hm... well 1st you havent deleted the moved-message 2nd i think it's a reference thread which should stay there but... well..it doesnt really matter

	want to thank or to support me? want that i'll become more knowledgeable and helpfull? Du willst mich unterstützen oder ne kleine Freude bereiten?
	WWW IP Logged

Shoeb Omar God Member Offline Mod Writer Posts: 5665 Location: San Diego Joined: Jun 29^th, 2001 Gender:	Re: [For Testing]SP1.2+ Notification fix Reply #8 - May 7^th, 2003 at 12:58pm	Print Post
	yeh my lockng solution was best .

	YaBB SP2 BETA! Now taking pay jobs in PHP or Perl. Contact me for details.
	WWW ICQ YIM AIM IP Logged

Pages: 1

‹ Previous Topic | Next Topic ›