Page Index Toggle Pages: 1 [2] 3 4 5 Send TopicPrint
Very Hot Topic (More than 25 Replies) [Done] Advanced System eMails Mod (Read 33849 times)
Deskdirect
Senior Member
****
Offline


"Living Drama Free!"

Posts: 498
Joined: Jul 1st, 2001
Re: [Beta] Advanced System eMails Mod
Reply #15 - Aug 11th, 2002 at 7:25pm
Print Post  
Is it just me or are steps 13 & 14 of the use with Notify mod redunant?

<search for>
           if($settings[7] eq 'Administrator') {
                 unlink("$memberdir/$member{'username'}.dat");
</search for>

<replace>
           if($settings[7] eq 'Administrator') {
# Advanced System eMails Mod
                &advsendmail3(14,$webmaster_email,$member{'username'},"");
# End Advanced System eMails Mod
                 unlink("$memberdir/$member{'username'}.dat");
</replace>

<search for>
           elsif( $member{'username'} eq $username ) {
                 unlink("$memberdir/$username.dat");
</search for>

<replace>
           elsif( $member{'username'} eq $username ) {
# Advanced System eMails Mod
                 &advsendmail3(13,$webmaster_email,$username,"");
# End Advanced System eMails Mod
                 unlink("$memberdir/$username.dat");
</replace>
  

Classic Rock Rocks!
http://www.mitchryder.com
Back to top
 
IP Logged
 
Christer Alexander
God Member
*****
Offline


Make my day...

Posts: 3443
Location: Lethbridge
Joined: Feb 10th, 2002
Gender: Male
Re: [Beta] Advanced System eMails Mod
Reply #16 - Aug 11th, 2002 at 8:24pm
Print Post  
I don't see any redundant stuff. It emails the webmaster when any member is deleted(or something to that extent)
  

Code
Select All
unless(0) { stab("LoonyPandora"); next; } 

Back to top
IP Logged
 
Pyrrhon
Full Member
***
Offline



Posts: 220
Joined: Oct 17th, 2001
Gender: Male
Re: [Beta] Advanced System eMails Mod
Reply #17 - Aug 12th, 2002 at 6:46am
Print Post  
Christer,

you are right.

In one of these case if the member deletes hisself, in the second case if the admin deletes the member via profile page. And there is a third elsewhere if the member is deleted via admin center. For self-deletion and admin deletation are two different templates in the mod.

In the next days I will add another system email to this mod which gets a member if he delets himself, an automatical "see you again"-mail. (of course also with the possibility to decative this mail).

Uwe
« Last Edit: Aug 14th, 2002 at 6:48am by Pyrrhon »  
Back to top
WWW  
IP Logged
 
Felix3232
Guest


Re: [Beta] Advanced System eMails Mod
Reply #18 - Aug 12th, 2002 at 7:13pm
Print Post  
When do you think this mod will be ready for release?
  
Back to top
 
IP Logged
 
Seawolf
Senior Member
****
Offline


YaBB - it's not just a
board, it's an OBSESSION!

Posts: 351
Location: Valparaiso
Joined: May 19th, 2002
Gender: Male
Re: [Beta] Advanced System eMails Mod
Reply #19 - Aug 13th, 2002 at 3:29pm
Print Post  
I think I've found a compatibility issue with IMBox 1.2. I created a test account to see the welcome IM's and it looks like the user.msg file isn't being written to correctly now after installation of Advanced E-mails.


IM #3 is what is generated to a new user. 1&2 are new additions since installing advanced IM's Clicking on any of them times out since the user.msg file is corrupted.

IM on here to you for URL, name and password info so you can check it out. Attaching the .msg file (zipped) so you can see what it's doing.
  

test.zip ( 0 KB | Downloads )
Back to top
ICQYIM  
IP Logged
 
Pyrrhon
Full Member
***
Offline



Posts: 220
Joined: Oct 17th, 2001
Gender: Male
Re: [Beta] Advanced System eMails Mod
Reply #20 - Aug 15th, 2002 at 5:21pm
Print Post  
Hallo Seawolf,

thank you for the hint. I have found the bug and will fix it as soon as possible. It is not a incompatibility but a real bug (some delphi code in a perl script )

I hope then it will be bugfree and, Felix,  if nobody finds any more bugs it will be done.

Pyrrhon aka Uwe
  
Back to top
WWW  
IP Logged
 
Seawolf
Senior Member
****
Offline


YaBB - it's not just a
board, it's an OBSESSION!

Posts: 351
Location: Valparaiso
Joined: May 19th, 2002
Gender: Male
Re: [Beta] Advanced System eMails Mod
Reply #21 - Aug 15th, 2002 at 6:28pm
Print Post  
Quite welcome, thanks for getting back to me. I'll go ahead and remove the mod from my board now that I know that you've looked at it and found the problem. Eagerly awaiting the fix. Smiley
  
Back to top
ICQYIM  
IP Logged
 
Pyrrhon
Full Member
***
Offline



Posts: 220
Joined: Oct 17th, 2001
Gender: Male
Re: [Beta] Advanced System eMails Mod
Reply #22 - Aug 16th, 2002 at 8:24pm
Print Post  
I have now bugfixed the mod. Moreover it supports now also "See you again emails" (if a user deletes his account he gets an email for example, that the webmaster hopes to see im later again). Moreover it is now compatible with the Notification Once Mod. The ling is in the first post of this thread.

Seawolf, I hope you can't find another bug, isn't it so?

Pyrrhon
  
Back to top
WWW  
IP Logged
 
Seawolf
Senior Member
****
Offline


YaBB - it's not just a
board, it's an OBSESSION!

Posts: 351
Location: Valparaiso
Joined: May 19th, 2002
Gender: Male
Re: [Beta] Advanced System eMails Mod
Reply #23 - Aug 19th, 2002 at 6:26am
Print Post  
Sorry to let you down, but the fix hasn't fixed the problem. I downloaded the new mod from the link (verified new because I saw the new e-mail in the center), but I still have the same problem when a new user and the IMBox. Same 3 messages with a corrupted file (same as before). I also noted an automatic uninstall problem with BoardMod on the last step, but that's minor and probably just a tab off somewhere (don't worry about that one for now).
  
Back to top
ICQYIM  
IP Logged
 
Seawolf
Senior Member
****
Offline


YaBB - it's not just a
board, it's an OBSESSION!

Posts: 351
Location: Valparaiso
Joined: May 19th, 2002
Gender: Male
Re: [Beta] Advanced System eMails Mod
Reply #24 - Aug 19th, 2002 at 7:35am
Print Post  
Disregard my last post, I just checked a new user account and it's doing it without advanced E-Mail installed. Looks like a problem with Advanced IMBox that's corrupting initial welcome IMs for me.
  
Back to top
ICQYIM  
IP Logged
 
Seawolf
Senior Member
****
Offline


YaBB - it's not just a
board, it's an OBSESSION!

Posts: 351
Location: Valparaiso
Joined: May 19th, 2002
Gender: Male
Re: [Beta] Advanced System eMails Mod
Reply #25 - Aug 21st, 2002 at 4:21pm
Print Post  
Reinstalled the mod, and resumed checking out the emails.

In the welcome message, the [profile] macro isn't inserting the url in the message but rather it inserts [profile]. The others that I tried ([mburl], [quote]) are working well.
  
Back to top
ICQYIM  
IP Logged
 
Pyrrhon
Full Member
***
Offline



Posts: 220
Joined: Oct 17th, 2001
Gender: Male
Re: [Beta] Advanced System eMails Mod
Reply #26 - Aug 21st, 2002 at 5:38pm
Print Post  
Sorry Seawolf,

for test purposes I have marked the [profile]-work as comment and forgot to delete the comment markers.

Now it should work.

Pyrrhon
  
Back to top
WWW  
IP Logged
 
Seawolf
Senior Member
****
Offline


YaBB - it's not just a
board, it's an OBSESSION!

Posts: 351
Location: Valparaiso
Joined: May 19th, 2002
Gender: Male
Re: [Beta] Advanced System eMails Mod
Reply #27 - Aug 21st, 2002 at 7:57pm
Print Post  
Yes, that fixed it - thanks. Attaching a repair of the mod file for step 19 - with the original version there is a spacing issue that won't allow it to uninstall automatically (and throws BoardMod2.5 into a continuous loop) This only fixes the spacing issue for non Notify Plus boards.

I also think there are spacing issues on other steps (3 was one and I don't remember which others) as well because when I went to auto install after uninstall, BM reported extra spaces. I bypassed this by modding my backup copy of my files.

I'll try to look at the spacing issues later and see if I can tighten it up for auto install and uninstall.
  
Back to top
ICQYIM  
IP Logged
 
Pyrrhon
Full Member
***
Offline



Posts: 220
Joined: Oct 17th, 2001
Gender: Male
Re: [Beta] Advanced System eMails Mod
Reply #28 - Aug 21st, 2002 at 8:48pm
Print Post  
Hi Seawolf,

I have not the talent to forecast and understand what boardmod really makes. Boardmod can't change the first line of a file and more then one empty lines correctly ...  But can you tell me which mistakes I have made writing step 19? 

Pyrrhon
  
Back to top
WWW  
IP Logged
 
Seawolf
Senior Member
****
Offline


YaBB - it's not just a
board, it's an OBSESSION!

Posts: 351
Location: Valparaiso
Joined: May 19th, 2002
Gender: Male
Re: [Beta] Advanced System eMails Mod
Reply #29 - Aug 22nd, 2002 at 5:07pm
Print Post  
No mistakes, it just didn't like how the code for the last step was inserted in regards to tabs or spaces in order to find it again so it could take it out. I can't tell you the precise area because the code was so dern big  Grin

All I did was open the ModEditor and my CodeMagic IDE and did a copy/paste from Subs.pl exactly as it was inserted in my Subs.pl to the step in the Mod editor and that resolved the auto uninstall issue with BM2.5

Spacing looks to be a real issue where you used search and replace (instead of add after or add before) but that could be coincidence.

I still haven't tightened up the spaces yet; will try to get to it today and then do some test installs and uninstalls on my test board and let you know.
  
Back to top
ICQYIM  
IP Logged
 
Page Index Toggle Pages: 1 [2] 3 4 5
Send TopicPrint